Skip to content

Replace custom SingleLinkedList with std::list #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

aentinger
Copy link
Contributor

No description provided.

@aentinger aentinger added the type: enhancement Proposed improvement label Jun 4, 2020
@aentinger aentinger self-assigned this Jun 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #130 into master will increase coverage by 0.21%.
The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   97.01%   97.23%   +0.21%     
==========================================
  Files          28       28              
  Lines         972      975       +3     
==========================================
+ Hits          943      948       +5     
+ Misses         29       27       -2     
Impacted Files Coverage Δ
src/cbor/ArduinoCloudProperty.h 100.00% <ø> (ø)
src/cbor/ArduinoCloudThing.cpp 95.68% <97.50%> (+0.69%) ⬆️
src/cbor/ArduinoCloudProperty.cpp 93.66% <100.00%> (+0.04%) ⬆️
src/cbor/ArduinoCloudThing.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d71ccf...34b5079. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 4, 2020

Memory usage change @34b50799c52bfd88ccf1de8a59d7617408526139

FQBN Flash Usage RAM For Global Variables
arduino:samd:mkr1000 💚 -1000 💚 -32
arduino:samd:mkrgsm1400 💚 -1000 💚 -32
arduino:samd:mkrnb1500 💚 -1000 💚 -32
arduino:samd:mkrwan1300 💚 -992 💚 -32
arduino:samd:mkrwifi1010 💚 -1000 💚 -32
arduino:samd:nano_33_iot 💚 -992 💚 -32
esp8266:esp8266:huzzah 💚 -1520 💚 -40

@aentinger
Copy link
Contributor Author

Successfully tested on PROD with

  • MKR 1000 ✔️
  • MKR WiFi 1010 ✔️
  • Nano 33 IoT ✔️
  • ESP8266 ✔️
  • MKR WAN 1310 ✔️

@aentinger aentinger merged commit 16512d4 into master Jun 4, 2020
@aentinger aentinger deleted the replace-list-with-stl branch June 4, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants